Fixed symbol zip file not being moved with Unity 2022, include non-batch mode build support. #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
CLA check is already passed. https://github.com/google/play-unity-plugins/pull/239/checks Unless this PR is incorporated, I am unable to resolve symbol names in crash reports for applications built with play-unity-plugins in Unity 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied change #226 to address an issue in Unity 2022.1 and later where symbol files were no longer being moved correctly because they now include the name of the scripting backend in the symbol file name.
At that time, Fixed a bug that caused an exception to be thrown when executing a build in non-batch mode because PlayerSettings.GetScriptingBackend was accessed from outside the main thread.